Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signer/rules:use goja instead of otto #685

Merged
merged 6 commits into from
Jul 14, 2020
Merged

signer/rules:use goja instead of otto #685

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25abc6b
signer/rules:use goja instead of otto
ShadowErii Jul 13, 2020
31fd36f
go vendor & go fmt
ucwong Jul 13, 2020
2d16e5d
to_string
ShadowErii Jul 13, 2020
c0e5202
fix
ShadowErii Jul 13, 2020
664deb2
..
ShadowErii Jul 13, 2020
06dbaca
fix bug in rules_test
ShadowErii Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
to_string
  • Loading branch information
@ShadowErii
ShadowErii committed Jul 13, 2020
commit 2d16e5dbddb4e9442e78ba141b6c2d9ae9157761
2 changes: 1 addition & 1 deletion signer/rules/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (r *rulesetUI) execute(jsfunc string, jsarg interface{}) (goja.Value, error
vm.Set("console", consoleObj)

// Load bootstrap libraries
script, err := goja.Compile("bignumber.js", BigNumber_JS,true)
script, err := goja.Compile("bignumber.js", string(BigNumber_JS),true)
if err != nil {
log.Warn("Failed loading libraries", "err", err)
return goja.Undefined(), err
Expand Down