Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce ops::Sub<Uint128> for Uint128 #858

Closed
webmaster128 opened this issue Apr 1, 2021 · 0 comments · Fixed by #936
Closed

Re-introduce ops::Sub<Uint128> for Uint128 #858

webmaster128 opened this issue Apr 1, 2021 · 0 comments · Fixed by #936
Assignees
@uint
Milestone
0.15.0

Comments

@webmaster128
Copy link
Member

In #853 (released as 0.14) impl ops::Sub<Uint128> for Uint128 and impl<'a> ops::Sub<&'a Uint128> for Uint128 were removed because they were not implemented with a panic on overflow (the behaviour of + for u128).

Let's wait some time until users migrated to the explicit *_sub methods. Then let's implement ops::Sub<Uint128> for Uint128 again with a panic on overflow (consistent with u128 and impl ops::Add<Uint128> for Uint128).
@webmaster128 webmaster128 mentioned this issue May 26, 2021
Closed
@uint uint self-assigned this Jun 7, 2021
uint added a commit that referenced this issue Jun 8, 2021
@uint
Implement Sub for Uint128 (closes #858)
d11944b
uint added a commit that referenced this issue Jun 8, 2021
@uint
Implement Sub for Uint128 (closes #858)
2c5f786
@webmaster128 webmaster128 added this to the 0.15.0 milestone Jun 8, 2021
@webmaster128 webmaster128 mentioned this issue Jun 8, 2021
Merged
uint added a commit that referenced this issue Jun 16, 2021
@uint
Implement Sub for Uint128 (closes #858)
5edb2c0
webmaster128 added a commit that referenced this issue Jun 16, 2021
@webmaster128
Merge pull request #936 from CosmWasm/impl-sub-for-uint128
ff0fab5 
Implement Sub and SubAssign for Uint128 (closes #858)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uint uint

Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Implement Sub and SubAssign for Uint128 (closes #858) CosmWasm/cosmwasm
2 participants
@uint @webmaster128