Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sub and SubAssign for Uint128 (closes #858) #936

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Implement Sub and SubAssign for Uint128 (closes #858) #936

merged 1 commit into from
Jun 16, 2021

Conversation

uint
Copy link
Contributor

@uint uint commented Jun 8, 2021 •
edited
Loading

Closes #858.

@webmaster128
Copy link
Member

Thanks. Added #858 to the 0.15.0 milestone now.

Could you write the "closes #858" annotation in the PR description? Then we get nice references on the GitHub web UI.

@uint uint marked this pull request as ready for review June 16, 2021 09:07
@uint uint requested a review from webmaster128 June 16, 2021 09:07
@uint
Copy link
Contributor Author

uint commented Jun 16, 2021

Rebased and added a CHANGELOG entry.

@webmaster128 webmaster128 merged commit ff0fab5 into main Jun 16, 2021
@webmaster128 webmaster128 deleted the impl-sub-for-uint128 branch June 16, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-introduce ops::Sub<Uint128> for Uint128
2 participants
@uint @webmaster128