Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k256 #1374

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Bump k256 #1374

merged 3 commits into from
Aug 1, 2022

Conversation

neacsu
Copy link
Contributor

@neacsu neacsu commented Jul 28, 2022

cosmrs 0.8 release bumped k256, which makes cargo unable to select compatible versions for signature dependency crate when building cosmwasm-std and cosmrs together.

This PR also bumps k256dependency with what should be minimal effect on cosmwasm-crypto [1] to remove the said incompatibility.

[1] k256 CHANGELOG: https://github.com/RustCrypto/elliptic-curves/blob/master/k256/CHANGELOG.md

Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes depends on paragraph from digest CHANGELOG:
https://github.com/RustCrypto/traits/blob/master/digest/CHANGELOG.md#changed-1

Dirty traits are removed and instead block-level traits are introduced. Variable output traits reworked and now support both run and compile time selection of output size.

right?
I'd only ask you to update our CHANGELOG with entry about bumping k256 and digest to appropriate versions.

@neacsu
Copy link
Contributor Author

neacsu commented Aug 1, 2022

Those changes depends on paragraph from digest CHANGELOG

Yes, that and a function rename.

I've updated the CHANGELOG as well.

Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contribution.

@ueco-jb ueco-jb merged commit 060230a into CosmWasm:main Aug 1, 2022
@neacsu neacsu deleted the neacsu/bump_k256 branch August 1, 2022 10:03
@shekohex
Copy link

shekohex commented Aug 1, 2022

@ueco-jb any plans on release a new version of this soon? like v1.0.1 for example?

@ueco-jb
Copy link
Contributor

ueco-jb commented Aug 1, 2022

@shekohex I think right now we are quite close to releasing 1.1.0.
https://github.com/CosmWasm/cosmwasm/milestone/18
@webmaster128 or do you see anything worth adding to that milestone before release?

@webmaster128
Copy link
Member

Looking at RustCrypto/signatures#409 (comment) and RustCrypto/utils#723 the core of this issue seems to be a MSRV problem, which causes ecdsa 0.13 and 0.14 being impossible to install in one project. This is very unfortunate but also not our bug. So I am hesitant to squeeze out a cosmwasm 1.0.1 patch release for that, especially given the non-trivial diff here (thank you by the way).

I think using latest master for your development and switching to 1.1.0 once it is out is a reasonable strategy.

@shekohex
Copy link

shekohex commented Aug 1, 2022

Sounds good, thank you @webmaster128 and @ueco-jb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants