Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle QueryMsg with generics when deriving the QueryResponses trait #1429

Merged
merged 7 commits into from
Sep 19, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Sep 19, 2022

Closes #1424

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only understand half of the magic but looks solid. Can you add a CHANGELOG entry?

CHANGELOG.md Outdated

[#1426]: https://github.com/CosmWasm/cosmwasm/issues/1426
[#1429]: https://github.com/CosmWasm/cosmwasm/issues/1429
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the PR number, not the issue number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fair. I only tested that the link works

@uint uint merged commit c468bcb into main Sep 19, 2022
@uint uint deleted the query-responses-generics branch September 19, 2022 14:24
};

let result = query_responses_derive_impl(input);
dbg!(&result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosmwasm_schema: macro generator ignores generics
3 participants