Fix backtraces feature #1613
Fix backtraces feature #1613
Conversation
| #![cfg_attr(feature = "backtraces", feature(backtrace))] | ||
| #![cfg_attr(feature = "backtraces", feature(error_generic_member_access))] | ||
| #![cfg_attr(feature = "backtraces", feature(provide_any))] |
There was a problem hiding this comment.
I see you are putting into life those changes from thiserror: https://github.com/dtolnay/thiserror/pull/182/files
|
Thank you for bringing this up, @toml01. Happy to look into it. However, could you keep the PR minimal and specific to one thing? It seems like the whole lockfile is updated for no reason, including a bump of schemars and as a result newly generated JSON Schemas. This is cool, but should get its own PR. You can sue the dev scripts from the main README to only perform minimal lockfile updates: # Updates ./Cargo.lock
./devtools/check_workspace.sh
# Updates ./contracts/**/Cargo.lock
./devtools/check_contracts_fast.sh |
|
The schemars upgrade is now here: #1617 |
|
@webmaster128 yeah I was just trying to make the tests pass. |
toml01
force-pushed
the
fix-backtraces-feature
branch
from
4edc542
to
4eb3279
Compare
|
@webmaster128 I think it looks good now, lmk if I can do anything else :) |
|
Published as part of 1.2.2 today |
The
backtracesfeature seems to be broken for a while now, this commit fixes it.