Add mocking capabilities for ibc querying #1620
Conversation
nik-suri
force-pushed
the
mock-ibc-querier
branch
from
5d207d3
to
1d574aa
Compare
nik-suri
force-pushed
the
mock-ibc-querier
branch
from
1d574aa
to
c19953d
Compare
|
@hashedone could you review this PR to ensure it serves your needs for multitest? |
There was a problem hiding this comment.
I don't exactly like the fact the implementation implements only half of the queried cases (querying "own" ports - I agree it is probably the most useful one, but with just a bit more work, the whole query domain could be covered).
It doesn't have much to do with multitest - it would have its query, and there would be a "mock" relayer passing messages, and opening channels, so it would simulate the chain behaviour.
|
@hashedone @webmaster128 thanks for your reviews. If there aren't any more reviewers, could we please merge this? |
| let ibc = IbcQuerier::new("myport", &[chan1]); | ||
|
|
||
| // query channels matching "myport" (should be none) | ||
| let query = &&IbcQuery::PortId {}; |
There was a problem hiding this comment.
I wonder why clippy is not complaining about this double reference 🤷♂️ But it seems to work.
There was a problem hiding this comment.
Seems like clippy hasn't implemented lints for useless borrows?
There was a problem hiding this comment.
Yeah. Anyways, fixed in #1624
|
Published as part of 1.2.2 today |
This PR adds an IBC querier implementation to the
MockQuerier. The functionality is gated by thestargatefeature.