[2.0] Add memo field to IbcMsg::Transfer
#1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Here is an interesting approach for a better Rust API using an Option: https://github.com/CosmWasm/cosmwasm/pull/1757/files. One in Go, there is no difference between None and "" anymore. But Option might be a nicer way of skipping. What do you think about it? (The type needs to be String instead of Binary in any case)
|
I think Option is more rusty. 👍 |
chipshort
force-pushed
the
1477-ibc-transfer-memo
branch
from
a6ddea1
to
9e21260
Compare
chipshort
force-pushed
the
1477-ibc-transfer-memo
branch
from
b8ac07b
to
5bda166
Compare
webmaster128
approved these changes
Oct 19, 2023
chipshort
force-pushed
the
1477-ibc-transfer-memo
branch
from
5bda166
to
eb2c9ce
Compare
webmaster128
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1477