[2.0] Response changes #1883
Merged
[2.0] Response changes #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
force-pushed
the
1559-non-exhaustive
branch
from
4b1934e
to
fc99133
Compare
chipshort
force-pushed
the
1559-non-exhaustive
branch
from
afe59e0
to
71d306c
Compare
webmaster128
reviewed
Nov 6, 2023
chipshort
force-pushed
the
1559-non-exhaustive
branch
from
71d306c
to
f6ba5ac
Compare
webmaster128
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1559
closes #1767
closes #1765
Not only the responses themselves, but also the structs contained are marked as
non_exhaustiveby this (exceptDecCoinbecause it seems very unlikely that anything is added here)I also removed the
Defaultimpls, changed the address types toAddrand replaced the constructor ofContractInfoResponsewith the macro-generated one.