Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Remove mixed uint decimal arithmetic #1890

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1485

This removes the mixed-type Mul impls.

I noticed we currently do not have the impl_mul_fraction for signed integers. Is that something we want to implement?

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Just the CHANGELOG/MIGRATING entries

@chipshort chipshort merged commit 18696df into main Oct 17, 2023
25 of 27 checks passed
@chipshort chipshort deleted the 1485-remove-mixed-arithmetic branch October 17, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mixed type arithmetic Decimal * Uint128
2 participants