Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count sum of all params over all functions #1991

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Count sum of all params over all functions #1991

merged 6 commits into from
Jan 24, 2024

Conversation

webmaster128
Copy link
Member

No description provided.

@chipshort chipshort mentioned this pull request Jan 18, 2024
Merged
webmaster128
webmaster128 commented Jan 22, 2024
View reviewed changes
packages/vm/src/parsed_wasm.rs Show resolved Hide resolved
packages/vm/src/parsed_wasm.rs Outdated Show resolved Hide resolved
packages/vm/src/parsed_wasm.rs Show resolved Hide resolved
packages/vm/src/parsed_wasm.rs Outdated Show resolved Hide resolved
webmaster128
webmaster128 commented Jan 22, 2024
View reviewed changes
Copy link
Member Author

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more ideas on limits. If we double the current limits, that should be enough. Then add a bite more space for the new limit.

packages/vm/src/compatibility.rs Outdated Show resolved Hide resolved
packages/vm/src/compatibility.rs Outdated Show resolved Hide resolved
packages/vm/src/compatibility.rs Outdated Show resolved Hide resolved
@webmaster128 webmaster128 added this to the 2.0.0 milestone Jan 23, 2024
@chipshort chipshort marked this pull request as ready for review January 24, 2024 11:58
webmaster128 and others added 6 commits January 24, 2024 23:18
@webmaster128
Count sum of all params over all functions
9aea77e
@chipshort @webmaster128
Restrict total number of function params
d77b110
@chipshort @webmaster128
Use Vec for type params analysis
6dfd998
@chipshort @webmaster128
Fix casing
e65d239 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@chipshort @webmaster128
Adjust function limits
81a69cb 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@webmaster128
Add CHANGELOG entry for #1991
2d8c0e2
@webmaster128 webmaster128 changed the base branch from release/1.5 to main January 24, 2024 22:21
@webmaster128 webmaster128 merged commit f69ffc7 into main Jan 24, 2024
27 checks passed
@webmaster128 webmaster128 deleted the area-under-curve branch January 24, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort Awaiting requested review from chipshort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@webmaster128 @chipshort