Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ibc entry points for ibc-enabled contracts #711

Merged
merged 15 commits into from
Jan 13, 2021
Merged

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jan 13, 2021

This allows contracts to implement their own application-protocol on top of IBC and participate in both the channel handshake phase as well as sending and receiving packets

@alpe Nice for you to have a look at it sometime, especially the ibc.rs types and ibc_exports.rs entry points

@ethanfrey ethanfrey marked this pull request as ready for review January 13, 2021 12:10
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/lib.rs Outdated Show resolved Hide resolved
packages/std/src/lib.rs Outdated Show resolved Hide resolved
packages/std/src/ibc_exports.rs Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Outdated Show resolved Hide resolved
Copy link
Member Author

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first review

packages/std/src/ibc.rs Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Outdated Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc.rs Show resolved Hide resolved
packages/std/src/ibc_exports.rs Outdated Show resolved Hide resolved
@ethanfrey
Copy link
Member Author

Okay, addressed last comments

@webmaster128 webmaster128 mentioned this pull request Jan 13, 2021
7 tasks
@webmaster128 webmaster128 merged commit cdeabd0 into master Jan 13, 2021
@webmaster128 webmaster128 deleted the ibc-entry-points branch January 13, 2021 20:07
@ethanfrey ethanfrey mentioned this pull request Jan 13, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants