Added setID method for changing device ID on the device ID type.
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turtledreams
requested changes
Jun 7, 2024
There was a problem hiding this comment.
awesome!
Tests validates device ID change.
But lets also add a validation for 'how' the device ID changes (merge or non merge).
For that we would have to check the request queue and see if there is the merge requests.
Also we can check if consents are revoked, session ended etc.
| @@ -228,7 +228,7 @@ - (void)startWithConfig:(CountlyConfig *)config | |||
| CountlyCrashReporter.sharedInstance.isEnabledOnInitialConfig = YES; | |||
| [CountlyCrashReporter.sharedInstance startCrashReporting]; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
why so sudden line tabs?
arifBurakDemiray
approved these changes
Jun 11, 2024
turtledreams
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.