Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SER-1505] Adding limit to digits behind the comma - Alerts Mail Notifications #5374

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions plugins/alerts/api/parts/common-lib.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ async function compileEmail(result) {
const host = await new Promise((res, rej) => mail.lookup((err, _host) => err ? rej(err) : res(_host)));
const metrics = [];
if (metricValue) {
metrics.push({ key: "Value now", value: metricValue });
metrics.push({ key: "Value now", value: formatMetricValue(metricValue) });
}
if (metricValueBefore) {
metrics.push({ key: "Value before", value: metricValueBefore });
metrics.push({ key: "Value before", value: formatMetricValue(metricValueBefore) });
}
return EMAIL_TEMPLATE({
title: `Countly Alert`,
Expand All @@ -189,6 +189,25 @@ async function compileEmail(result) {
}]
});
}
/**
* Formats the metric value to ensure it maintains its type.
* If the value is a number, it rounds to 2 decimal places if necessary.
* Otherwise, it returns the value as is.
*
* @param {number|string} value - The value to be formatted.
* @returns {number|string} The formatted value, maintaining the original type.
*/
function formatMetricValue(value) {
if (typeof value === 'number' && value === parseFloat(value.toFixed(2))) {
return value;
}
else if (typeof value === 'number') {
return parseFloat(value.toFixed(2));
}
else {
return value;
}
}

/**
* Starts triggering alerts matched with their conditions.
Expand Down
Loading