Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update newsletter check #5381

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Update newsletter check #5381

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6a8f58
Update newsletter check
widatama Jun 28, 2024
9f57cb8
Merge branch 'master' into nletter
kanwarujjaval Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update newsletter check
  • Loading branch information
@widatama
widatama committed Jun 28, 2024
commit e6a8f58444a63dafee4cfe060b7fef0c38fbac9d
2 changes: 1 addition & 1 deletion frontend/express/public/core/onboarding/javascripts/countly.views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@
app.navigate("/not-responded-consent", true);
}
}
else if (hasNewsLetter && (!countlyGlobal.member.subscribe_newsletter && !store.get('disable_newsletter_prompt') && (countlyGlobal.member.login_count === 3 || moment().dayOfYear() % 90 === 0))) {
else if (hasNewsLetter && (typeof countlyGlobal.member.subscribe_newsletter !== 'boolean' && !store.get('disable_newsletter_prompt') && (countlyGlobal.member.login_count === 3 || moment().dayOfYear() % 90 === 0))) {
if (Backbone.history.fragment !== '/not-subscribed-newsletter' && !/initial-setup|initial-consent/.test(window.location.hash)) {
app.navigate("/not-subscribed-newsletter", true);
}
Expand Down
Loading