Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

used httparty gem directly instead of unmaintained httmultiparty gem #1

Merged
merged 1 commit into from
Aug 18, 2022
Merged

used httparty gem directly instead of unmaintained httmultiparty gem #1

merged 1 commit into from
Aug 18, 2022

Conversation

haseebeqx
Copy link

@haseebeqx haseebeqx commented Aug 17, 2022 •
edited by ponny
Loading

Remove HttMultiParty gem and use httparty directly

Removes HttpMultiparty gem in favour of httparty gem as the former is outdated

Type of change

Cleanup

Related issues

Fix GLM-2464

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@haseebeqx haseebeqx self-assigned this Aug 17, 2022
@haseebeqx haseebeqx marked this pull request as ready for review August 18, 2022 07:06
@haseebeqx
Copy link
Author

@ponny Tested all soundcloud actions in the app. All of them are working fine.

@haseebeqx haseebeqx assigned ponny and unassigned haseebeqx Aug 18, 2022
@haseebeqx haseebeqx requested a review from ponny August 18, 2022 07:09
ponny
ponny approved these changes Aug 18, 2022
View reviewed changes
Copy link

@ponny ponny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done!

@ponny ponny merged commit 53f10de into master Aug 18, 2022
@ponny ponny deleted the glm-2468-remove-dependency-on-dead-gem branch August 18, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponny ponny ponny approved these changes

Assignees

@ponny ponny

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@haseebeqx @ponny