generate an atom feed #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for this. I think I messed up the commits so the dates are probably not correct from there. I have managed to send on every thursday since starting so that's the correct dates. Maybe it doesn't matter so much them being correct into the past. Would you mind looking into testing with a standard reader and/or finding some online validation tools. I don't use RSS so it'd be good to have a bit more testing |
|
Good point, proper validation is key. Unfortunately, the w3 validator had a few complaints which required a PR to xmleam: tovedetered/xmleam#2 I hope this can be fixed soon :/ |
in accordance with the official spec https://validator.w3.org/ - use correct date format - add a type for contained html - use hrefs for links - add a self-type link
|
n.b. I used https://validator.w3.org/feed/#validate_by_input to validate the generated xml |
|
Great thank you. I will try and get to this this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the email now also generates an atom feed. This does however require adding a date to all issues. For existing issues I determined the publishing date from the git history.
I tested the generated feed with my home-cooked feed reader so it would be best if you test it again before merging.