fix: Resolve panic in Decoder.Skip() with corrupt message
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converted run.skip-files to issues.exclude-rules updated test code under example/ to clear linter warnings
wmorgan6796
approved these changes
Aug 15, 2024
dylan-bourque
force-pushed
the
fix/panic-in-decoder-skip-with-corrupt-message
branch
from
2d1363d
to
02f92b4
Compare
…de()` added length validation in `DecodeBytes()`, `DecodeNested()`, and `Skip()` on `Decoder` added tests
dylan-bourque
force-pushed
the
fix/panic-in-decoder-skip-with-corrupt-message
branch
from
02f92b4
to
0112c2a
Compare
dylan-bourque
deleted the
fix/panic-in-decoder-skip-with-corrupt-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a panic when trying to decode a corrupted message, specifically one where the encoded length of a string field is >2GB.
I also added a new
ParseAnnotatedHex()function in a newprototestpackage. This function can be used to convert a string containing a "commented" hexadecimal representation of an encoded Protobuf message into binary, which is useful for managing test data in a more human-readable form. See the godoc comments on the function for more details.Finally, I updated
.golangci.ymlto resolve some config deprecations, which led to having to update some test code that was now generating linter warnings.Fixes #158