fix: Unmarshal should fail if required fields are missing #16

dylan-bourque · 2022-04-13T20:10:22Z

updated codegen templates to emit checks that all required fields are assigned during unmarshal
added associated tests
regenerated all examples

Resolves #12

This PR also includes tweaks to the linter setup (see #2) so that we also lint the nested module in example/ and skip linting test files

update linter config to skip linting test code update `lint` Make target to include the `example/` sub-module Issue: #2

updated codegen templates to emit checks that all required fields are assigned during unmarshal added associated tests regenerated all examples Issue: #12

scarlson

LGTM

dylan-bourque added 2 commits April 13, 2022 14:58

chore: tweak project linting

9da5a92

update linter config to skip linting test code update `lint` Make target to include the `example/` sub-module Issue: #2

fix: Unmarshal should fail if required fields are missing

ec53232

updated codegen templates to emit checks that all required fields are assigned during unmarshal added associated tests regenerated all examples Issue: #12

dylan-bourque requested a review from scarlson April 13, 2022 20:10

scarlson approved these changes Apr 13, 2022

View reviewed changes

dylan-bourque merged commit 7ae88ee into main Apr 13, 2022

dylan-bourque deleted the fix/fail-on-missing-required-fields branch April 13, 2022 20:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Unmarshal should fail if required fields are missing #16

fix: Unmarshal should fail if required fields are missing #16

dylan-bourque commented Apr 13, 2022

scarlson left a comment

fix: Unmarshal should fail if required fields are missing #16

fix: Unmarshal should fail if required fields are missing #16

Conversation

dylan-bourque commented Apr 13, 2022

scarlson left a comment

Choose a reason for hiding this comment