feat: support proto3 map fields #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmorgan6796
approved these changes
Apr 11, 2022
added a new `EncodeMapEntryHeader()` function to `Encoder` extended codegen templates to handle "message" fields that are actually map entry values added new `AllTheMaps` message types in examples for all 3 runtimes added bidirectional validation tests for messages containing maps regenerated all examples update `test` Make target to test sub-packages in `examples/` Issue: #3
dylan-bourque
force-pushed
the
feat/support-proto3-map-fields
branch
from
ee23614
to
027cb40
Compare
redhatrises
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a new
EncodeMapEntryHeader()function toEncoderextended codegen templates to handle "message" fields that are actually map entry values
added new
AllTheMapsmessage types in examples for all 3 runtimesadded bidirectional validation tests for messages containing maps
regenerated all examples
update
testMake target to test sub-packages inexamples/resolves #3