Avoid panics when decoding invalid messages #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added bounds checks to all paths in `Decoder` to prevent panics added unit and fuzz test for `Decoder.DecodeTag()`
updated Google V1 path in `ExtensionFieldNumber()` to address linter warning added unit tests for `ExtensionFieldNumber()`
dylan-bourque
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bounds checks to all paths in
Decoderto avoid panics when attempting to decode invalid/corrupt Protobuf messages. The changes had a minimal impact on benchmarks, so the general safety is a net win.I also addressed a new linter warning that was introduced in v0.15.0 and added unit tests for the
ExtensionFieldNumber(any) intfunction