Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect error unmarshaling empty buffer when using protoc-gen-fastmarshal #95

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

dylan-bourque
Copy link
Collaborator

Updated codegen templates to not return an error when Unmarshal() is called with an empty buffer. Regenerated all examples

Fixes #89

…fastmarshal

updated codegen templates to not return an error when `Unmarshal()` is called with an empty buffer
regenerated all examples
Copy link

@wmorgan6796 wmorgan6796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dylan-bourque dylan-bourque merged commit 579dcb5 into main Dec 21, 2022
@dylan-bourque dylan-bourque deleted the fix/error-when-unmarshaling-empty-buffer branch December 21, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc-gen-fastmarshal generated code fails to unmarshal empty protov2 message
2 participants