Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #20

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Update README.md #20

merged 2 commits into from
Apr 20, 2020

Conversation

portlek
Copy link
Contributor

@portlek portlek commented Apr 19, 2020

No description provided.

@CryptoMorin
Copy link
Owner

How does the ${version} work tho? Is there anywhere I can read about it?

@portlek
Copy link
Contributor Author

portlek commented Apr 20, 2020

How does the ${version} work tho? Is there anywhere I can read about it?

It won't work,It's just a placeholder that users should replace with the maven-central case.

@CryptoMorin
Copy link
Owner

I see, can you change it to version then? It kinda looks like a bug when you set it as ${version}

@portlek
Copy link
Contributor Author

portlek commented Apr 20, 2020

If I change it, we shall change it every version changing. So this is a problem actually. We may forget to change the version number. Users should know the latest version unless we change it in the readme.

@CryptoMorin
Copy link
Owner

No no. I mean change it to "version". Literally the word "version".

@portlek
Copy link
Contributor Author

portlek commented Apr 20, 2020

alright

@CryptoMorin CryptoMorin merged commit dc5ead5 into CryptoMorin:master Apr 20, 2020
@portlek portlek deleted the patch-1 branch April 21, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants