Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(170567) Users can revoke a DAO project #1699

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

mec
Copy link
Contributor

@mec mec commented Jun 26, 2024

We have almost everything in place to allow users to revoke a DAO.

This work adds a check to each step to ensure the project is appropriate i.e. a
conversion with a DAO.

It then adds the UI for users to start the process, this is linked in the side
navigation and only shown as appropriate.

Based on #1701

@mec mec force-pushed the feature/170567-user-can-revoke-a-dao-project branch 3 times, most recently from b3c7639 to 75138d0 Compare June 27, 2024 13:54
mec added 3 commits June 27, 2024 16:12
This show view is never rendered because projects redirect to their
tasks list on show.

The /app/views/projects/show/_task_list is not used either.
If a user were to try and run the DAO Revoke paths on a project that is
no suitable, we want to redirect a show an error message.
This work exposes the new 'DAO revocation' UI to users. It follows the
same pattern as the 'completing a project' UI.

We show a link and some brief guidance at the bottom of the task list
of appropriate projects. We also add a link to the side navigation. The
logic for showing the links in the side bar is the same as that of
showing the guidance and links.
@mec mec force-pushed the feature/170567-user-can-revoke-a-dao-project branch from 75138d0 to 9ceb645 Compare June 27, 2024 15:12
@mec mec marked this pull request as ready for review June 27, 2024 15:16
Copy link

sonarcloud bot commented Jun 27, 2024

@lozette lozette merged commit 4cec6a0 into main Jun 28, 2024
7 checks passed
@lozette lozette deleted the feature/170567-user-can-revoke-a-dao-project branch June 28, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants