Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

Bump shoulda-matchers from 4.3.0 to 4.4.0 #324

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps shoulda-matchers from 4.3.0 to 4.4.0.

Release notes

Sourced from shoulda-matchers's releases.

v4.4.0

Features

  • Add an ignoring_check_for_db_index qualifier to the have_secure_token matcher, since has_secure_token encourages use of an index but does not enforce it. (#1278)

  • Add allow_blank to validate_length_of to match other validation matchers. (#725, #1318)

  • Add new matcher have_implicit_order_column which can be used to test the implicit_order_column setting for ActiveRecord models under Rails 6+. (#1243)

  • Add a new is_other_than qualifier to validate_numericality_of to be able to test the numericality validation's :other_than option. (#1282)

  • Add a new have_one_attached and have_many_attached matchers for testing the new model-level ActiveStorage macros in Rails 6. (#1102)

#1278: thoughtbot/shoulda-matchers#1278 #725: thoughtbot/shoulda-matchers#725 #1318: thoughtbot/shoulda-matchers#1318 #1243: thoughtbot/shoulda-matchers#1243 #1282: thoughtbot/shoulda-matchers#1282 #1102: thoughtbot/shoulda-matchers#1102

Bug fixes

  • Fix performance of allow_value so that it doesn't hang if the given value is really long. (#1290)

  • Fix have_many so that it is possible to test an association that has a scope that takes an argument. (#952, #992)

  • Update validate_uniqueness_of to use the public validators_on instead of the private _validators when reading validations off of a model. This enables shoulda-matchers to be used with the [schema_validations] gem. (#995)

  • Update validate_uniqueness_of to work with scopes that are time columns. (#1190)

  • Fix have_and_belong_to_many so that when using the join_table qualifier you can pass a symbol rather than a string. (#1323)

#1290: thoughtbot/shoulda-matchers#952 #952: thoughtbot/shoulda-matchers#952 #992: thoughtbot/shoulda-matchers#992 [schema_validations]: https://github.com/SchemaPlus/schema_validations

Changelog

Sourced from shoulda-matchers's changelog.

4.4.0 - 2020-08-25

Bug fixes

  • Fix performance of allow_value so that it doesn't hang if the given value is really long. (#1290)

  • Fix have_many so that it is possible to test an association that has a scope that takes an argument. (#952, #992)

  • Update validate_uniqueness_of to use the public validators_on instead of the private _validators when reading validations off of a model. This enables shoulda-matchers to be used with the [schema_validations] gem. (#995)

  • Update validate_uniqueness_of to work with scopes that are time columns. (#1190)

  • Fix have_and_belong_to_many so that when using the join_table qualifier you can pass a symbol rather than a string. (#1323)

#1290: thoughtbot/shoulda-matchers#952 #952: thoughtbot/shoulda-matchers#952 #992: thoughtbot/shoulda-matchers#992 [schema_validations]: https://github.com/SchemaPlus/schema_validations #995: thoughtbot/shoulda-matchers#995 #1190: thoughtbot/shoulda-matchers#1190 #1323: thoughtbot/shoulda-matchers#1323

Features

  • Add an ignoring_check_for_db_index qualifier to the have_secure_token matcher, since has_secure_token encourages use of an index but does not enforce it. (#1278)

  • Add allow_blank to validate_length_of to match other validation matchers. (#725, #1318)

  • Add new matcher have_implicit_order_column which can be used to test the implicit_order_column setting for ActiveRecord models under Rails 6+. (#1243)

  • Add a new is_other_than qualifier to validate_numericality_of to be able to test the numericality validation's :other_than option. (#1282)

  • Add a new have_one_attached and have_many_attached matchers for testing the new model-level ActiveStorage macros in Rails 6. (#1102)

#1278: thoughtbot/shoulda-matchers#1278 #725: thoughtbot/shoulda-matchers#725

Commits
  • c8cd836 Release v4.4.0
  • e7dde36 Add have_attached_matcher to the Readme
  • 781bfca Update CHANGELOG
  • ce78101 Use autoloading instead of requiring all files up front
  • bd13bec Be consistent with order of headers in changelog
  • d1be1f7 Update CHANGELOG
  • 6a0e436 Remove warnings that fail the build
  • 412ea1f Use warnings_logger instead of warnings_spy
  • ef82150 word_wrap: fix Ruby 2.7 warning
  • 97b9701 Use Ruby 2.7 for development and CI
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 26, 2020
@aliuk2012 aliuk2012 temporarily deployed to ghwt-review-pr-324 August 26, 2020 06:57 Inactive
@aldavidson
Copy link
Contributor

Looks like this has broken things for many other people too: v4.4.0 NoMethodError: undefined method `belong_to' #1332

Let's wait until 4.4.1 comes out :)

@aldavidson aldavidson closed this Aug 26, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/shoulda-matchers-4.4.0 branch August 26, 2020 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants