Make app compliant - Solves icewind1991#25

DJaeger · Feb 8, 2019 · 1c9f900 · 1c9f900
1 parent 987bdf5
commit 1c9f900
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 16 deletions.
diff --git a/appinfo/info.xml b/appinfo/info.xml
@@ -2,6 +2,7 @@
 <info>
 	<id>files_external_dropbox</id>
 	<name>External Storage backend for Dropbox</name>
+	<summary>Integrate Dropbox as an external storage</summary>
 	<description>
 		This application enables integrating Dropbox external storages via the
 		Dropbox API v2.
@@ -17,33 +18,33 @@
 		configuration options in the 'Storage' section of admin and user
 		settings, respectively.
 	</description>
-	<summary>Integrate Dropbox as an external storage</summary>
+
+	<version>1.1.0</version>
 	<licence>agpl</licence>
 	<author>Robin Appelman</author>
 	<author>Hemant Mann</author>
-	<version>1.1.0</version>
-	<category>files</category>
+
+	<types>
+		<filesystem/>
+	</types>
+
 	<documentation>
-		<admin>
-			https://docs.nextcloud.com/server/12/admin_manual/configuration_files/external_storage/dropbox.html
-		</admin>
+		<admin>https://docs.nextcloud.com/server/12/admin_manual/configuration_files/external_storage/dropbox.html</admin>
 	</documentation>
+
+	<category>files</category>
+
+	<website>https://github.com/icewind1991/files_external_dropbox/</website>
+	<bugs>https://github.com/icewind1991/files_external_dropbox/issues</bugs>
+	<repository type="git">https://github.com/icewind1991/files_external_dropbox.git</repository>
 	<screenshot>
 		https://raw.githubusercontent.com/icewind1991/files_external_dropbox/master/screenshots/screenshots-app-external-storage-dropbox.jpg
 	</screenshot>
 	<screenshot>
 		https://raw.githubusercontent.com/icewind1991/files_external_dropbox/master/screenshots/settings.png
 	</screenshot>
-	<types>
-		<filesystem/>
-	</types>
 
 	<dependencies>
 		<nextcloud min-version="14.0" max-version="15.0"/>
 	</dependencies>
-	<website>https://github.com/icewind1991/files_external_dropbox/</website>
-	<bugs>https://github.com/icewind1991/files_external_dropbox/issues</bugs>
-	<repository type="git">
-		https://github.com/icewind1991/files_external_dropbox.git
-	</repository>
 </info>
diff --git a/lib/Controller/OauthController.php b/lib/Controller/OauthController.php
@@ -80,13 +80,13 @@ public function receiveToken(
 			$dropbox = new \Kunnu\Dropbox\Dropbox($app);
 			$authHelper = $dropbox->getAuthHelper();
 
-			if ($step == 1) {
+			if ($step === 1) {
 				$authUrl = $authHelper->getAuthUrl($redirect);
 				return new DataResponse([
 					'status' => 'success',
 					'data' => ['url' => $authUrl]
 				]);
-			} else if ($step == 2 && isset($code)) {
+			} else if ($step === 2 && isset($code)) {
 				try {
 					$accessToken = $authHelper->getAccessToken($code, null, $redirect);
 					return new DataResponse([