Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake adjustments for building with OpenCascade 7.5 #1017

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

sdeinert
Copy link
Collaborator

Description

The number of features linked into TiGL was reduced in CMake to only selected used features.
A minor change in TIGLQAspectWindow to allow building with OpenCASCADE 7.5

How Has This Been Tested?

Not

Screenshots, that help to understand the changes(if applicable):

None

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

Modified the CMake files for the case that no OCE was found to limit the number of unused libraries linked into TiGL
Adjustments for OCC v7.5
Adjustments to build with OCC 7.5
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.91%. Comparing base (1908230) to head (5d58cdf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1017   +/-   ##
=======================================
  Coverage   69.91%   69.91%           
=======================================
  Files         299      299           
  Lines       24244    24244           
=======================================
  Hits        16949    16949           
  Misses       7295     7295           
Flag Coverage Δ
unittests 69.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@joergbrech joergbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@joergbrech joergbrech merged commit fd4cf85 into master Jul 17, 2024
17 checks passed
@joergbrech joergbrech deleted the occ_cmake branch July 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants