Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++-ify rungard. #2344

Merged
merged 8 commits into from
Jun 11, 2024
Merged

C++-ify rungard. #2344

merged 8 commits into from
Jun 11, 2024

Conversation

meisterT
Copy link
Member

No description provided.

@meisterT
Copy link
Member Author

This is the next steps of merging runguard and runpipe (https://docs.google.com/document/d/1WZRwdvJUamsczYC7CpP3ZIBU8xG6wNqYqrNJf7osxYs/edit).

No functional changes intended. Small commits so it should be easy-ish to follow.

judge/Makefile Show resolved Hide resolved
judge/runguard.cc Show resolved Hide resolved
judge/runguard.cc Outdated Show resolved Hide resolved
Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume you tested this with doing a replay of an old contest?

@meisterT
Copy link
Member Author

meisterT commented Jun 6, 2024

LGTM, I assume you tested this with doing a replay of an old contest?

I did some limited testing on a few interactive and non-interactive problems so far, but I would like to do more testing before merging.

@meisterT
Copy link
Member Author

meisterT commented Jun 9, 2024

I did now a replay of a contest with ~1000 submissions. There was a single submission where the verdict changed and it was random (with main and this PR).

@meisterT meisterT added this pull request to the merge queue Jun 11, 2024
Merged via the queue into DOMjudge:main with commit bbdfa25 Jun 11, 2024
22 checks passed
@meisterT meisterT deleted the cppify branch June 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants