Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Buildcheck Workflow Revamp #1099

Merged
merged 14 commits into from
Feb 2, 2024
Merged

Frontend Buildcheck Workflow Revamp #1099

merged 14 commits into from
Feb 2, 2024

Conversation

prishavall
Copy link
Contributor

Frontend Buildcheck Workflow Revamp

#1086
What user problem are we solving?
Creating a unified Frontend build check workflow to ensure code quality and consistency
What solution does this PR provide?
This creates the build check along with pnpm features and a specific working directory point to the frontend
Testing Methodology

How did you test your changes and verify that existing functionality is not broken
Tested using vscode and general tests.
Any other considerations

@prishavall prishavall requested a review from a team as a code owner January 17, 2024 02:45
@farisdurrani
Copy link
Member

Please fix build errors @prishavall

@DSGT-DLP DSGT-DLP deleted a comment from sweep-ai bot Jan 17, 2024
@DSGT-DLP DSGT-DLP deleted a comment from sweep-ai bot Jan 17, 2024
@DSGT-DLP DSGT-DLP deleted a comment from sweep-ai bot Jan 17, 2024
@DSGT-DLP DSGT-DLP deleted a comment from sweep-ai bot Jan 17, 2024
frontend/package.json Outdated Show resolved Hide resolved
@farisdurrani
Copy link
Member

Apologies for the delay, @prishavall . I'm okay with the changes and I'll merge this in for you

@farisdurrani farisdurrani added this pull request to the merge queue Feb 2, 2024
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Merged via the queue into nextjs with commit b67f7d0 Feb 2, 2024
4 checks passed
@farisdurrani farisdurrani deleted the feature-1086 branch February 2, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants