Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify github actions to push to aws #1182

Merged
merged 7 commits into from
May 18, 2024
Merged

Conversation

andrewpeng02
Copy link
Contributor

@andrewpeng02 andrewpeng02 commented May 15, 2024

Modify github actions to push training and django containers to AWS

Github Issue Number Here: #1136
What user problem are we solving?
Following #1136 , we want to ensure that we can push the django docker container to the ECS fargate service django, and push the training docker container to the ECS service training with EC2 launch type

What solution does this PR provide?
I modified the Terraform plan and github actions slightly

Testing Methodology

  1. From dlp-terraform/ecs, run terraform apply, ensuring the name of your AWS profile is set correctly in main.tf
  2. Go into the AWS console to see what the alb URL is, and update the corresponding line in next.config.js
  3. Start SST. From serverless, run AWS_PROFILE=dlp pnpm run dev
  4. Run the "ECS Django Container Deployment" and "ECS Training Container Deployment", ensuring you select this branch
  5. Run ENVIRONMENT=production dlp-cli frontend start locally. If the env var is set, it proxies requests to AWS
  6. Try training a tabular model
Screen.Recording.2024-05-16.at.9.54.57.PM.mov

Any other considerations
None

@andrewpeng02 andrewpeng02 requested a review from a team as a code owner May 15, 2024 14:34
Copy link
Contributor

sweep-ai bot commented May 15, 2024

Sweep: PR Review

Sweep is currently reviewing your pr...

@karkir0003
Copy link
Member

@andrewpeng02 is there a short video you can attach to demo the testing?

frontend/next.config.js Outdated Show resolved Hide resolved
Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few questions

@andrewpeng02 andrewpeng02 force-pushed the andrew-deploy-to-aws branch 5 times, most recently from 20c58fd to cb0331b Compare May 17, 2024 02:54
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrewpeng02 andrewpeng02 added this pull request to the merge queue May 18, 2024
Merged via the queue into nextjs with commit bed1107 May 18, 2024
22 checks passed
@andrewpeng02 andrewpeng02 deleted the andrew-deploy-to-aws branch May 18, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants