Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change date picker to year input in renew ITA flow #2289

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

Fbasham
Copy link
Member

@Fbasham Fbasham commented Oct 15, 2024

Description

changes the date picker to an InputPatternField. This removes a lot if input validation as a byproduct. Additional validation such as years in the future or a partner age >150 can be re-added if necessary.

Related Azure Boards Work Items

AB#4714

Screenshots (if applicable)

Screenshot from 2024-10-15 09-11-31

Checklist

  • I have tested the changes locally
  • I have updated the documentation if necessary
  • I have added/updated tests that prove my fix is effective or that my feature works
  • I have checked that my code follows the project's coding style by running npm run format:check
  • I have checked that my code contains no linting errors by running npm run lint
  • I have checked that my code contains no type errors by running npm run typecheck
  • I have checked that all unit tests pass by running npm run test:unit -- run
  • I have checked that all e2e tests pass by running npm run test:e2e

nicholas-ly
nicholas-ly previously approved these changes Oct 15, 2024
@Fbasham Fbasham merged commit 7612e97 into main Oct 15, 2024
2 checks passed
@Fbasham Fbasham deleted the fb-partner-year branch October 15, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants