Fix broken declaration file #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregory-j-baker
approved these changes
Mar 1, 2024
sebastien-comeau
force-pushed
the
fix-ts-declaration-file
branch
from
10af891
to
b66e8c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per title.
Additional Notes
Since we have
"skipLibCheck": true,intsconfig.jsonfile. The declartion files are not validated. I had to set it tofalsethen fix it then set it back totrue. At the moment, there is no way to only skip-lib-checknode_modules.microsoft/TypeScript#30511