Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

126 need to add charge id into the reconstruction code #127

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

AsaNehm
Copy link
Contributor

@AsaNehm AsaNehm commented Aug 1, 2024

This copies/moves the charge ID code from Xiaoyan directly into the reconstruction (pattern recognition) and makes it available as a property of the 3D tracks

@AsaNehm AsaNehm linked an issue Aug 1, 2024 that may be closed by this pull request
@jdkio
Copy link
Contributor

jdkio commented Aug 2, 2024

Do you want to add it as a branch in the TreeWriter so it's saved?

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Aug 2, 2024

Do you want to add it as a branch in the TreeWriter so it's saved?

That's a really good suggestion. I completely forgot about that. Will add it in

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Aug 20, 2024

Xiaoyan gave his ok. Jeffrey asked for validation plots

@AsaNehm AsaNehm removed the request for review from xiaoyan1997 August 22, 2024 12:01
Copy link
Contributor

@jdkio jdkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AsaNehm AsaNehm assigned AsaNehm and unassigned AsaNehm Aug 23, 2024
@xiaoyan1997
Copy link
Member

i tested the branch on 3 samples, worked well.

@AsaNehm AsaNehm merged commit 47e48bf into main Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add charge ID into the reconstruction code
3 participants