Kleykamp issue 158 #162
Merged
Kleykamp issue 158 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsaNehm
reviewed
Sep 25, 2024
src/TMS_Reco.cpp
Outdated
| Accumulator[i][c_bin]++; | ||
| // Fill the accumulator, but only within bounds | ||
| // We don't care about lines outside of bounds | ||
| if (i > 0 && c_bin > 0 && i < nSlope && c_bin < nIntercept) Accumulator[i][c_bin]++; |
There was a problem hiding this comment.
The two conditions for i should be redundant with the for loop definition.
Also why only above 0 for i? With the loop starting at 0, the first 'row' for the slope would never get a hit which doesn't make sense to me.
The two conditions for c_bin are fine
There was a problem hiding this comment.
Oops yes, it should be i >= 0 && c_bin >= 0. I know that technically i will never be below zero but I made it a strong check just in case something changes
LiamOS
approved these changes
Sep 25, 2024
AsaNehm
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recent issues with crashes. They were mostly caused by array indices that were outside the range,
make sanitizeis good at finding thoseAlso found some cases of reco y positions being outside the TMS, which caused a regular crash. See issue #160. Didn't fix it but instead made Material class throw
invalid_argumentexception that the Kalman filter than catches and ignoresYou can find example output here made from running over 14 files from the most recent microprod:
/exp/dune/data/users/kleykamp/dune-tms/2024-09-24_test_23rd_version.tmsreco.rootSeparate files and logs in
/exp/dune/data/users/kleykamp/dune-tms/2024-09-24_test_23rd_version/. Current validation plot (a bit messy rn) can be found in/exp/dune/data/users/kleykamp/dune-tms/Validation/Tracking_Validation/2024-09-24_test_23rd_version.tmsreco_images. See also issue #161