Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50 missing hits and starts and ends of tracks #51

Merged
merged 12 commits into from
Jan 8, 2024

Conversation

AsaNehm
Copy link
Contributor

@AsaNehm AsaNehm commented Dec 21, 2023

No description provided.

@AsaNehm AsaNehm linked an issue Dec 21, 2023 that may be closed by this pull request
@AsaNehm
Copy link
Contributor Author

AsaNehm commented Dec 22, 2023

It ran on the Fermilab computers, so I'm not really sure what is happening here...

@LiamOS
Copy link
Member

LiamOS commented Dec 26, 2023

The CI tests failed while installing dependencies because apt failed so it never even got to building the changed software. I'll close this one but when you get a chance open another one and if it builds (looks like it will) and makes sense to merge I can do it.

@LiamOS LiamOS closed this Dec 26, 2023
@AsaNehm AsaNehm reopened this Jan 8, 2024
Copy link
Member

@LiamOS LiamOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Config]

  • Changed MergeTracks default to True.

[General]

  • Hits trailing the end of a Hough Track can now be added to the track they 'should' correspond to. Currently this defaults to on, will be switchable later.

@LiamOS LiamOS merged commit bd25b33 into main Jan 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing hits and starts and ends of tracks
2 participants