Skip to content

Commit

Permalink
ALSA: opl3sa2 fix irq releasing and short name of card
Browse files Browse the repository at this point in the history
Two simple fixes:

1. Use the same pointer for the free_irq() and
   the request_irq() calls.

2. A short name of card is appended with '2' or '3'
   character depending on a detected chip. Remove
   the '2' character from the short name.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Krzysztof-H authored and tiwai committed Mar 2, 2009
1 parent ce71bfd commit 1713c0d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/isa/opl3sa2.c
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ static void snd_opl3sa2_free(struct snd_card *card)
{
struct snd_opl3sa2 *chip = card->private_data;
if (chip->irq >= 0)
free_irq(chip->irq, (void *)chip);
free_irq(chip->irq, card);
release_and_free_resource(chip->res_port);
}

Expand All @@ -630,7 +630,7 @@ static struct snd_card *snd_opl3sa2_card_new(int dev)
if (card == NULL)
return NULL;
strcpy(card->driver, "OPL3SA2");
strcpy(card->shortname, "Yamaha OPL3-SA2");
strcpy(card->shortname, "Yamaha OPL3-SA");
chip = card->private_data;
spin_lock_init(&chip->reg_lock);
chip->irq = -1;
Expand Down

0 comments on commit 1713c0d

Please sign in to comment.