Skip to content

Commit

Permalink
BUG_ON() Conversion in drivers/video/
Browse files Browse the repository at this point in the history
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
  • Loading branch information
SesterhennEric authored and AdrianBunk committed Mar 24, 2006
1 parent b749455 commit 232443e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions drivers/video/bw2.c
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,7 @@ static void bw2_init_one(struct sbus_dev *sdev)
} else
#else
{
if (!sdev)
BUG();
BUG_ON(!sdev);
all->par.physbase = sdev->reg_addrs[0].phys_addr;
resp = &sdev->resource[0];
sbusfb_fill_var(&all->info.var, (sdev ? sdev->prom_node : 0), 1);
Expand Down
3 changes: 1 addition & 2 deletions drivers/video/ffb.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,8 +466,7 @@ static void ffb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
unsigned long flags;
u32 fg;

if (rect->rop != ROP_COPY && rect->rop != ROP_XOR)
BUG();
BUG_ON(rect->rop != ROP_COPY && rect->rop != ROP_XOR);

fg = ((u32 *)info->pseudo_palette)[rect->color];

Expand Down

0 comments on commit 232443e

Please sign in to comment.