Skip to content

Commit

Permalink
spi: spidev_test: Use perror() only if errno is not 0
Browse files Browse the repository at this point in the history
It is better to use perror() only if errno is not 0, it should use printf()
when errno is 0, otherwise there exists redudant ": Success".

E.g. without this patch:

$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected: Success
Aborted (core dumped)

With this patch:

$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected
Aborted (core dumped)

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Tiezhu Yang authored and broonie committed Feb 13, 2020
1 parent 1f3c363 commit 470a072
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion tools/spi/spidev_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <getopt.h>
#include <fcntl.h>
#include <time.h>
Expand All @@ -26,7 +27,11 @@

static void pabort(const char *s)
{
perror(s);
if (errno != 0)
perror(s);
else
printf("%s\n", s);

abort();
}

Expand Down

0 comments on commit 470a072

Please sign in to comment.