Skip to content

Commit

Permalink
pcmcia: Use global PCI rescan-remove locking
Browse files Browse the repository at this point in the history
Multiple race conditions are possible between the cardbus PCI device
addition and removal and the generic PCI bus rescan and device removal that
can be triggered via sysfs.

To avoid those race conditions make the cardbus code use global PCI
rescan-remove locking.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
rafaeljw authored and bjorn-helgaas committed Jan 14, 2014
1 parent 9217a98 commit 5ef68e8
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/pcmcia/cardbus.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ int __ref cb_alloc(struct pcmcia_socket *s)
struct pci_dev *dev;
unsigned int max, pass;

pci_lock_rescan_remove();

s->functions = pci_scan_slot(bus, PCI_DEVFN(0, 0));
pci_fixup_cardbus(bus);

Expand All @@ -93,6 +95,7 @@ int __ref cb_alloc(struct pcmcia_socket *s)

pci_bus_add_devices(bus);

pci_unlock_rescan_remove();
return 0;
}

Expand All @@ -115,6 +118,10 @@ void cb_free(struct pcmcia_socket *s)
if (!bus)
return;

pci_lock_rescan_remove();

list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list)
pci_stop_and_remove_bus_device(dev);

pci_unlock_rescan_remove();
}

0 comments on commit 5ef68e8

Please sign in to comment.