Skip to content

Commit

Permalink
io_uring: don't use TIF_NOTIFY_SIGNAL to test for availability of tas…
Browse files Browse the repository at this point in the history
…k_work

Use task_work_pending() as a better test for whether we have task_work
or not, TIF_NOTIFY_SIGNAL is only valid if the any of the task_work
items had been queued with TWA_SIGNAL as the notification mechanism.
Hence task_work_pending() is a more reliable check.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
axboe committed Dec 17, 2022
1 parent 44a84da commit 6434ec0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions io_uring/io_uring.h
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,7 @@ static inline int io_run_task_work(void)

static inline bool io_task_work_pending(struct io_ring_ctx *ctx)
{
return test_thread_flag(TIF_NOTIFY_SIGNAL) ||
!wq_list_empty(&ctx->work_llist);
return task_work_pending(current) || !wq_list_empty(&ctx->work_llist);
}

static inline int io_run_task_work_ctx(struct io_ring_ctx *ctx)
Expand Down

0 comments on commit 6434ec0

Please sign in to comment.