Skip to content

Commit

Permalink
9p: apply common request code to trans_fd
Browse files Browse the repository at this point in the history
Apply the now common p9_req_t structure to the fd transport.

Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
  • Loading branch information
ericvh committed Oct 17, 2008
1 parent ff68345 commit 673d62c
Show file tree
Hide file tree
Showing 4 changed files with 126 additions and 172 deletions.
10 changes: 9 additions & 1 deletion include/net/9p/client.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,12 @@ enum p9_trans_status {
* enum p9_req_status_t - virtio request status
* @REQ_STATUS_IDLE: request slot unused
* @REQ_STATUS_ALLOC: request has been allocated but not sent
* @REQ_STATUS_UNSENT: request waiting to be sent
* @REQ_STATUS_SENT: request sent to server
* @REQ_STATUS_FLSH: a flush has been sent for this request
* @REQ_STATUS_RCVD: response received from server
* @REQ_STATUS_FLSHD: request has been flushed
* @REQ_STATUS_ERR: request encountered an error on the client side
* @REQ_STATUS_ERROR: request encountered an error on the client side
*
* The @REQ_STATUS_IDLE state is used to mark a request slot as unused
* but use is actually tracked by the idpool structure which handles tag
Expand All @@ -64,6 +65,7 @@ enum p9_trans_status {
enum p9_req_status_t {
REQ_STATUS_IDLE,
REQ_STATUS_ALLOC,
REQ_STATUS_UNSENT,
REQ_STATUS_SENT,
REQ_STATUS_FLSH,
REQ_STATUS_RCVD,
Expand All @@ -79,6 +81,8 @@ enum p9_req_status_t {
* @tc: the request fcall structure
* @rc: the response fcall structure
* @aux: transport specific data (provided for trans_fd migration)
* @tag: tag on request (BUG: redundant)
* @req_list: link for higher level objects to chain requests
*
* Transport use an array to track outstanding requests
* instead of a list. While this may incurr overhead during initial
Expand All @@ -99,6 +103,9 @@ struct p9_req_t {
struct p9_fcall *rc;
u16 flush_tag;
void *aux;

int tag;
struct list_head req_list;
};

/**
Expand Down Expand Up @@ -207,5 +214,6 @@ struct p9_stat *p9_client_dirread(struct p9_fid *fid, u64 offset);

struct p9_req_t *p9_tag_alloc(struct p9_client *, u16);
struct p9_req_t *p9_tag_lookup(struct p9_client *, u16);
void p9_free_req(struct p9_client *, struct p9_req_t *);

#endif /* NET_9P_CLIENT_H */
21 changes: 21 additions & 0 deletions net/9p/client.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,27 @@ static void p9_tag_cleanup(struct p9_client *c)
c->max_tag = 0;
}

/**
* p9_free_req - free a request and clean-up as necessary
* c: client state
* r: request to release
*
*/

void p9_free_req(struct p9_client *c, struct p9_req_t *r)
{
r->flush_tag = P9_NOTAG;
r->status = REQ_STATUS_IDLE;
if (r->tc->tag != P9_NOTAG && p9_idpool_check(r->tc->tag, c->tagpool))
p9_idpool_put(r->tc->tag, c->tagpool);

/* if this was a flush request we have to free response fcall */
if (r->tc->id == P9_TFLUSH) {
kfree(r->tc);
kfree(r->rc);
}
}

static struct p9_fid *p9_fid_create(struct p9_client *clnt)
{
int err;
Expand Down
Loading

0 comments on commit 673d62c

Please sign in to comment.