Skip to content

Commit

Permalink
userns: Replace user_ns_map_uid and user_ns_map_gid with from_kuid an…
Browse files Browse the repository at this point in the history
…d from_kgid

These function are no longer needed replace them with their more useful equivalents.

Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
  • Loading branch information
ebiederm committed May 3, 2012
1 parent 078de5f commit 76b6db0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 17 deletions.
12 changes: 0 additions & 12 deletions include/linux/user_namespace.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,4 @@ static inline void put_user_ns(struct user_namespace *ns)

#endif

static inline uid_t user_ns_map_uid(struct user_namespace *to,
const struct cred *cred, kuid_t uid)
{
return from_kuid_munged(to, uid);
}

static inline gid_t user_ns_map_gid(struct user_namespace *to,
const struct cred *cred, kgid_t gid)
{
return from_kgid_munged(to, gid);
}

#endif /* _LINUX_USER_H */
3 changes: 1 addition & 2 deletions ipc/mqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,7 @@ static void __do_notify(struct mqueue_inode_info *info)
rcu_read_lock();
sig_i.si_pid = task_tgid_nr_ns(current,
ns_of_pid(info->notify_owner));
sig_i.si_uid = user_ns_map_uid(info->notify_user_ns,
current_cred(), current_uid());
sig_i.si_uid = from_kuid_munged(info->notify_user_ns, current_uid());
rcu_read_unlock();

kill_pid_info(info->notify.sigev_signo,
Expand Down
2 changes: 1 addition & 1 deletion kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ static inline int legacy_queue(struct sigpending *signals, int sig)
static inline uid_t map_cred_ns(const struct cred *cred,
struct user_namespace *ns)
{
return user_ns_map_uid(ns, cred, cred->uid);
return from_kuid_munged(ns, cred->uid);
}

#ifdef CONFIG_USER_NS
Expand Down
4 changes: 2 additions & 2 deletions net/core/sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -821,8 +821,8 @@ void cred_to_ucred(struct pid *pid, const struct cred *cred,
if (cred) {
struct user_namespace *current_ns = current_user_ns();

ucred->uid = user_ns_map_uid(current_ns, cred, cred->euid);
ucred->gid = user_ns_map_gid(current_ns, cred, cred->egid);
ucred->uid = from_kuid(current_ns, cred->euid);
ucred->gid = from_kgid(current_ns, cred->egid);
}
}
EXPORT_SYMBOL_GPL(cred_to_ucred);
Expand Down

0 comments on commit 76b6db0

Please sign in to comment.