Skip to content

Commit

Permalink
[CRYPTO] skcipher: Move chainiv/seqiv into crypto_blkcipher module
Browse files Browse the repository at this point in the history
For compatibility with dm-crypt initramfs setups it is useful to merge
chainiv/seqiv into the crypto_blkcipher module.  Since they're required
by most algorithms anyway this is an acceptable trade-off.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
herbertx committed Feb 23, 2008
1 parent c8620c2 commit 76fc60a
Show file tree
Hide file tree
Showing 6 changed files with 45 additions and 21 deletions.
4 changes: 2 additions & 2 deletions crypto/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ obj-$(CONFIG_CRYPTO_AEAD) += aead.o

crypto_blkcipher-objs := ablkcipher.o
crypto_blkcipher-objs += blkcipher.o
crypto_blkcipher-objs += chainiv.o
crypto_blkcipher-objs += eseqiv.o
obj-$(CONFIG_CRYPTO_BLKCIPHER) += crypto_blkcipher.o
obj-$(CONFIG_CRYPTO_BLKCIPHER) += chainiv.o
obj-$(CONFIG_CRYPTO_BLKCIPHER) += eseqiv.o
obj-$(CONFIG_CRYPTO_SEQIV) += seqiv.o

crypto_hash-objs := hash.o
Expand Down
3 changes: 0 additions & 3 deletions crypto/ablkcipher.c
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,3 @@ struct crypto_ablkcipher *crypto_alloc_ablkcipher(const char *alg_name,
return ERR_PTR(err);
}
EXPORT_SYMBOL_GPL(crypto_alloc_ablkcipher);

MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Asynchronous block chaining cipher type");
29 changes: 29 additions & 0 deletions crypto/blkcipher.c
Original file line number Diff line number Diff line change
Expand Up @@ -696,5 +696,34 @@ void skcipher_geniv_exit(struct crypto_tfm *tfm)
}
EXPORT_SYMBOL_GPL(skcipher_geniv_exit);

static int __init blkcipher_module_init(void)
{
int err;

err = chainiv_module_init();
if (err)
goto out;

err = eseqiv_module_init();
if (err)
goto eseqiv_err;

out:
return err;

eseqiv_err:
chainiv_module_exit();
goto out;
}

static void __exit blkcipher_module_exit(void)
{
eseqiv_module_exit();
chainiv_module_exit();
}

module_init(blkcipher_module_init);
module_exit(blkcipher_module_exit);

MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Generic block chaining cipher type");
12 changes: 4 additions & 8 deletions crypto/chainiv.c
Original file line number Diff line number Diff line change
Expand Up @@ -314,18 +314,14 @@ static struct crypto_template chainiv_tmpl = {
.module = THIS_MODULE,
};

static int __init chainiv_module_init(void)
int __init chainiv_module_init(void)
{
return crypto_register_template(&chainiv_tmpl);
}
EXPORT_SYMBOL_GPL(chainiv_module_init);

static void __exit chainiv_module_exit(void)
void __exit chainiv_module_exit(void)
{
crypto_unregister_template(&chainiv_tmpl);
}

module_init(chainiv_module_init);
module_exit(chainiv_module_exit);

MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Chain IV Generator");
EXPORT_SYMBOL_GPL(chainiv_module_exit);
12 changes: 4 additions & 8 deletions crypto/eseqiv.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,18 +247,14 @@ static struct crypto_template eseqiv_tmpl = {
.module = THIS_MODULE,
};

static int __init eseqiv_module_init(void)
int __init eseqiv_module_init(void)
{
return crypto_register_template(&eseqiv_tmpl);
}
EXPORT_SYMBOL_GPL(eseqiv_module_init);

static void __exit eseqiv_module_exit(void)
void __exit eseqiv_module_exit(void)
{
crypto_unregister_template(&eseqiv_tmpl);
}

module_init(eseqiv_module_init);
module_exit(eseqiv_module_exit);

MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Encrypted Sequence Number IV Generator");
EXPORT_SYMBOL_GPL(eseqiv_module_exit);
6 changes: 6 additions & 0 deletions include/crypto/internal/skcipher.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

#include <crypto/algapi.h>
#include <crypto/skcipher.h>
#include <linux/init.h>
#include <linux/types.h>

struct rtattr;
Expand Down Expand Up @@ -64,6 +65,11 @@ void skcipher_geniv_free(struct crypto_instance *inst);
int skcipher_geniv_init(struct crypto_tfm *tfm);
void skcipher_geniv_exit(struct crypto_tfm *tfm);

int __init eseqiv_module_init(void);
void __exit eseqiv_module_exit(void);
int __init chainiv_module_init(void);
void __exit chainiv_module_exit(void);

static inline struct crypto_ablkcipher *skcipher_geniv_cipher(
struct crypto_ablkcipher *geniv)
{
Expand Down

0 comments on commit 76fc60a

Please sign in to comment.