Skip to content

Commit

Permalink
crypto: af_alg - use list_for_each_entry() in af_alg_count_tsgl()
Browse files Browse the repository at this point in the history
af_alg_count_tsgl() iterates through a list without modifying it, so use
list_for_each_entry() rather than list_for_each_entry_safe().  Also make
the pointers 'const' to make it clearer that nothing is modified.

No actual change in behavior.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
ebiggers authored and herbertx committed Jan 18, 2019
1 parent 466e075 commit 7c39edf
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions crypto/af_alg.c
Original file line number Diff line number Diff line change
Expand Up @@ -530,17 +530,17 @@ static int af_alg_alloc_tsgl(struct sock *sk)
*/
unsigned int af_alg_count_tsgl(struct sock *sk, size_t bytes, size_t offset)
{
struct alg_sock *ask = alg_sk(sk);
struct af_alg_ctx *ctx = ask->private;
struct af_alg_tsgl *sgl, *tmp;
const struct alg_sock *ask = alg_sk(sk);
const struct af_alg_ctx *ctx = ask->private;
const struct af_alg_tsgl *sgl;
unsigned int i;
unsigned int sgl_count = 0;

if (!bytes)
return 0;

list_for_each_entry_safe(sgl, tmp, &ctx->tsgl_list, list) {
struct scatterlist *sg = sgl->sg;
list_for_each_entry(sgl, &ctx->tsgl_list, list) {
const struct scatterlist *sg = sgl->sg;

for (i = 0; i < sgl->cur; i++) {
size_t bytes_count;
Expand Down

0 comments on commit 7c39edf

Please sign in to comment.