Skip to content

Commit

Permalink
[PATCH] knfsd: fix return value for writes to some files in 'nfsd' fi…
Browse files Browse the repository at this point in the history
…lesystem

Most files in the 'nfsd' filesystem are transactional.  When you write, a
reply is generated that can be read back only on the same 'file'.

If the reply has zero length, the 'write' will incorrectly return a value of
'0' instead of the length that was written.  This causes 'rpc.nfsd' to give an
annoying warning.

This patch fixes the test.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
neilbrown authored and Linus Torvalds committed Feb 14, 2007
1 parent 754ce4f commit 8971a10
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfsd/nfsctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ static ssize_t nfsctl_transaction_write(struct file *file, const char __user *bu
return PTR_ERR(data);

rv = write_op[ino](file, data, size);
if (rv>0) {
if (rv >= 0) {
simple_transaction_set(file, rv);
rv = size;
}
Expand Down

0 comments on commit 8971a10

Please sign in to comment.