Skip to content

Commit

Permalink
RDS: Clear up some confusing code in send_remove_from_sock
Browse files Browse the repository at this point in the history
The previous code was correct, but made the assumption that
if r_notifier was non-NULL then either r_recverr or r_notify
was true. Valid, but fragile. Changed to explicitly check
r_recverr (shows up in greps for recverr now, too.)

Signed-off-by: Andy Grover <andy.grover@oracle.com>
  • Loading branch information
Andy Grover committed Sep 9, 2010
1 parent f4dd96f commit a63273d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/rds/send.c
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ void rds_send_remove_from_sock(struct list_head *messages, int status)
rds_send_sndbuf_remove(rs, rm);

if (ro->r_active && ro->r_notifier &&
(status || ro->r_notify)) {
(ro->r_notify || (ro->r_recverr && status))) {
notifier = ro->r_notifier;
list_add_tail(&notifier->n_list,
&rs->rs_notify_queue);
Expand Down

0 comments on commit a63273d

Please sign in to comment.