Skip to content

Commit

Permalink
drm/i915/display/frontbuffer: Prefer drm_WARN_ON over WARN_ON
Browse files Browse the repository at this point in the history
struct drm_device specific drm_WARN* macros include device information
in the backtrace, so we know what device the warnings originate from.

Prefer drm_WARN_ON over WARN_ON.

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200406112800.23762-9-pankaj.laxminarayan.bharadiya@intel.com
  • Loading branch information
bpankajl authored and jnikula committed Apr 21, 2020
1 parent 4ad53ed commit a7f2ad3
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/gpu/drm/i915/display/intel_frontbuffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,14 @@ void intel_frontbuffer_track(struct intel_frontbuffer *old,
BITS_PER_TYPE(atomic_t));

if (old) {
WARN_ON(!(atomic_read(&old->bits) & frontbuffer_bits));
drm_WARN_ON(old->obj->base.dev,
!(atomic_read(&old->bits) & frontbuffer_bits));
atomic_andnot(frontbuffer_bits, &old->bits);
}

if (new) {
WARN_ON(atomic_read(&new->bits) & frontbuffer_bits);
drm_WARN_ON(new->obj->base.dev,
atomic_read(&new->bits) & frontbuffer_bits);
atomic_or(frontbuffer_bits, &new->bits);
}
}

0 comments on commit a7f2ad3

Please sign in to comment.