Skip to content

Commit

Permalink
devm_memremap: convert to return ERR_PTR
Browse files Browse the repository at this point in the history
Make devm_memremap consistent with the error return scheme of
devm_memremap_pages to remove special casing in the pmem driver.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
djbw committed Oct 9, 2015
1 parent d741314 commit b36f476
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
16 changes: 6 additions & 10 deletions drivers/nvdimm/pmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,19 +150,15 @@ static struct pmem_device *pmem_alloc(struct device *dev,
return ERR_PTR(-EBUSY);
}

if (pmem_should_map_pages(dev)) {
void *addr = devm_memremap_pages(dev, res);

if (IS_ERR(addr))
return addr;
pmem->virt_addr = (void __pmem *) addr;
} else {
if (pmem_should_map_pages(dev))
pmem->virt_addr = (void __pmem *) devm_memremap_pages(dev, res);
else
pmem->virt_addr = (void __pmem *) devm_memremap(dev,
pmem->phys_addr, pmem->size,
ARCH_MEMREMAP_PMEM);
if (!pmem->virt_addr)
return ERR_PTR(-ENXIO);
}

if (IS_ERR(pmem->virt_addr))
return (void __force *) pmem->virt_addr;

return pmem;
}
Expand Down
2 changes: 1 addition & 1 deletion kernel/memremap.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ void *devm_memremap(struct device *dev, resource_size_t offset,

ptr = devres_alloc(devm_memremap_release, sizeof(*ptr), GFP_KERNEL);
if (!ptr)
return NULL;
return ERR_PTR(-ENOMEM);

addr = memremap(offset, size, flags);
if (addr) {
Expand Down

0 comments on commit b36f476

Please sign in to comment.