fix the leak in integrity_read_file()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
DX37 · Jan 4, 2016 · cc4e719 · cc4e719
1 parent 7812bf1
commit cc4e719
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/security/integrity/iint.c b/security/integrity/iint.c
@@ -234,12 +234,13 @@ int __init integrity_read_file(const char *path, char **data)
 	}
 
 	rc = integrity_kernel_read(file, 0, buf, size);
-	if (rc < 0)
-		kfree(buf);
-	else if (rc != size)
-		rc = -EIO;
-	else
+	if (rc == size) {
 		*data = buf;
+	} else {
+		kfree(buf);
+		if (rc >= 0)
+			rc = -EIO;
+	}
 out:
 	fput(file);
 	return rc;