Skip to content

Commit

Permalink
net: Remove unnecessary semicolons after switch statements
Browse files Browse the repository at this point in the history
Also added an explicit break; to avoid
a fallthrough in net/ipv4/tcp_input.c

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
JoePerches authored and davem330 committed May 18, 2010
1 parent 935e2a2 commit ccbd6a5
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion net/8021q/vlan_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ int vlan_hwaccel_do_receive(struct sk_buff *skb)
dev->dev_addr))
skb->pkt_type = PACKET_HOST;
break;
};
}
return 0;
}

Expand Down
4 changes: 2 additions & 2 deletions net/core/ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ static int ethtool_get_rx_ntuple(struct net_device *dev, void __user *useraddr)
p += ETH_GSTRING_LEN;
num_strings++;
goto unknown_filter;
};
}

/* now the rest of the filters */
switch (fsc->fs.flow_type) {
Expand Down Expand Up @@ -646,7 +646,7 @@ static int ethtool_get_rx_ntuple(struct net_device *dev, void __user *useraddr)
p += ETH_GSTRING_LEN;
num_strings++;
break;
};
}
sprintf(p, "\tVLAN: %d, mask: 0x%x\n",
fsc->fs.vlan_tag, fsc->fs.vlan_tag_mask);
p += ETH_GSTRING_LEN;
Expand Down
2 changes: 1 addition & 1 deletion net/ipv4/tcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2215,7 +2215,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
default:
/* fallthru */
break;
};
}

if (optlen < sizeof(int))
return -EINVAL;
Expand Down
5 changes: 3 additions & 2 deletions net/ipv4/tcp_input.c
Original file line number Diff line number Diff line change
Expand Up @@ -3845,12 +3845,13 @@ void tcp_parse_options(struct sk_buff *skb, struct tcp_options_received *opt_rx,
/* 16-bit multiple */
opt_rx->cookie_plus = opsize;
*hvpp = ptr;
break;
default:
/* ignore option */
break;
};
}
break;
};
}

ptr += opsize-2;
length -= opsize;
Expand Down
2 changes: 1 addition & 1 deletion net/rds/tcp_connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ void rds_tcp_conn_shutdown(struct rds_connection *conn)

release_sock(sock->sk);
sock_release(sock);
};
}

if (tc->t_tinc) {
rds_inc_put(&tc->t_tinc->ti_inc);
Expand Down
2 changes: 1 addition & 1 deletion net/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -2615,7 +2615,7 @@ static int bond_ioctl(struct net *net, unsigned int cmd,
return dev_ioctl(net, cmd, uifr);
default:
return -EINVAL;
};
}
}

static int siocdevprivate_ioctl(struct net *net, unsigned int cmd,
Expand Down
6 changes: 3 additions & 3 deletions net/xfrm/xfrm_hash.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static inline unsigned __xfrm_src_hash(xfrm_address_t *daddr,
case AF_INET6:
h ^= __xfrm6_daddr_saddr_hash(daddr, saddr);
break;
};
}
return (h ^ (h >> 16)) & hmask;
}

Expand Down Expand Up @@ -102,7 +102,7 @@ static inline unsigned int __sel_hash(struct xfrm_selector *sel, unsigned short

h = __xfrm6_daddr_saddr_hash(daddr, saddr);
break;
};
}
h ^= (h >> 16);
return h & hmask;
}
Expand All @@ -119,7 +119,7 @@ static inline unsigned int __addr_hash(xfrm_address_t *daddr, xfrm_address_t *sa
case AF_INET6:
h = __xfrm6_daddr_saddr_hash(daddr, saddr);
break;
};
}
h ^= (h >> 16);
return h & hmask;
}
Expand Down

0 comments on commit ccbd6a5

Please sign in to comment.